Dev/attitude tests - #61
Open
Srishti-KuttyKrishnan wants to merge 4 commits into
Open
Conversation
Replacing test.py with a folder of test files
because this file contained simulation info, not unit or integration tests
wlodaralex
requested changes
Jul 10, 2026
| ) | ||
|
|
||
| plt.figure() | ||
| plt.plot(t, qnorm) |
Collaborator
There was a problem hiding this comment.
Could you just confirm in a reply that the norm remains 1 throughout the simulation?
Collaborator
There was a problem hiding this comment.
Nevermind, I see that gets tested in the other file. But now I'm wondering what this file is for?
Collaborator
Author
There was a problem hiding this comment.
I had initially put this simulation code from the original MATLAB file in the main attitude py file, but you suggested they be moved to a different file so they live here now. Should I delete/move them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.