feat: adicionar histórico de expedições na landing page - #3
Merged
BorniaPedro merged 3 commits intoSep 10, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Address the FAB overlap and missing accordion accessibility state in Home.tsx.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a collapsible expedition-history section to the landing page using typed mock data, reusable cards, and supporting icons.
Changes:
- Added expedition types and temporary mock data.
- Implemented expandable history cards with status, date, and location.
- Updated scrolling layout and supporting icons.
File summaries
| File | Summary | Review notes |
|---|---|---|
src/domain/home/types.ts |
Defines the expedition model. | No final comments. |
src/domain/home/Home.tsx |
Integrates the accordion and scrolling behavior. | Moderate (1 vote): increase bottom padding to prevent FAB overlap. Moderate (3 votes): expose the accordion’s accessibility role and expanded state. |
src/domain/home/expeditions-mock.ts |
Provides temporary expedition history data. | No final comments. |
src/domain/home/components/HistoryExpeditionCard.tsx |
Renders individual expedition cards. | No final comments. |
Review details
Suppressed comments (1)
src/domain/home/Home.tsx:193
- Because the FAB is absolutely positioned with height 56 and bottom 87, the new 96px bottom padding is not enough to keep the end of the expanded history above it. After scrolling to the end, the last card can remain underneath the FAB by 47px, making its lower content difficult to reach. Increase this padding to at least the FAB's occupied height (or derive it from the FAB and safe-area insets).
paddingBottom: 96,
- Files reviewed: 4/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+87
to
+90
| <Pressable | ||
| style={styles.historyButton} | ||
| onPress={() => setIsHistoryOpen(prev => !prev)} | ||
| > |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que foi feito
Implementação da seção retrátil de histórico de expedições na landing page, seguindo o protótipo do Figma.
ExpeditionHistoryCard(layout em linha com badges de status, local e data).calendar,pinechevron).types.tse inclusão de dados temporários emexpeditions-mock.ts.ScrollViewpara navegação fluida.