Skip to content

Feat/pagination page size 1#1047

Open
harshi-web-cyber wants to merge 3 commits into
utksh1:mainfrom
harshi-web-cyber:feat/pagination-page-size-1
Open

Feat/pagination page size 1#1047
harshi-web-cyber wants to merge 3 commits into
utksh1:mainfrom
harshi-web-cyber:feat/pagination-page-size-1

Conversation

@harshi-web-cyber

@harshi-web-cyber harshi-web-cyber commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Description

Related Issues

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes. This PR mixes two unrelated frontend changes: API key paste sanitization and scan pagination page-size persistence. It also currently fails . Please split these into separate focused PRs and fix formatting; the pagination change should also include tests or at least align with the existing Pagination component contract.

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes. This PR mixes two unrelated frontend changes: API key paste sanitization and scan pagination page-size persistence. It also currently fails formatting-hygiene. Please split these into separate focused PRs and fix formatting; the pagination change should also include tests or at least align with the existing Pagination component contract.

@utksh1 utksh1 added level:beginner 20 pts difficulty label for small beginner-friendly PRs type:feature Feature work category bonus label area:frontend Frontend React/UI work labels Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Frontend React/UI work level:beginner 20 pts difficulty label for small beginner-friendly PRs type:feature Feature work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants