test : added unit tests for CacheClient helpers#1080
Open
tmdeveloper007 wants to merge 4 commits into
Open
Conversation
utksh1
requested changes
Jun 20, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Requesting changes. The tests mutate the global cache settings object directly and do not restore it, which can leak state into later tests. Please use monkeypatch or a local Settings override and keep the cache tests isolated.
Use MagicMock() to completely replace cache_module.settings instead of mutating the global settings singleton. The fixture now restores the original reference after each test instead of relying on monkeypatch to restore a mutated attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1075.
Summary of What Has Been Done:
Added testing/backend/unit/test_cache.py covering the CacheClient class in backend.secuscan.cache. The class implements an in-memory TTL cache with LRU eviction. 15 tests, all passing.
Changes Made:
Impact it Made:
Zero test coverage for the cache module. CacheClient is used throughout the API for response caching. Untested, TTL bugs could cause stale data to persist indefinitely and LRU eviction bugs could cause unbounded memory growth.
Note: This task is being handled by tmdeveloper007 — please assign to that account when picking it up.