Skip to content

Fix: Resolve search filter controls overlap on findings page (#901)#1098

Open
sahare-mayur-0071 wants to merge 1 commit into
utksh1:mainfrom
sahare-mayur-0071:fix-findings-layout-overlap-901
Open

Fix: Resolve search filter controls overlap on findings page (#901)#1098
sahare-mayur-0071 wants to merge 1 commit into
utksh1:mainfrom
sahare-mayur-0071:fix-findings-layout-overlap-901

Conversation

@sahare-mayur-0071

Copy link
Copy Markdown
Contributor

Fixes #901

  • Updated the filter container in \Findings.tsx\ to use flex column instead of forcing components inline via rigid grid templates on large screens.
  • Limited filter grid to a max of 4 columns, preventing inputs from becoming too narrow and clipping text.
  • Assigned \min-w-0\ to field containers to ensure they respect the grid cells.
  • Stacked the actions controls below the filter grid to guarantee they don't crash into each other.

@utksh1 utksh1 added level:intermediate 35 pts difficulty label for moderate contributor PRs type:bug Bug fix work category bonus label area:frontend Frontend React/UI work area:ci CI, tooling, or automation work labels Jun 20, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes. This mixes a Findings layout fix with a CI branch-protection roll-up job. Please split the CI workflow change from the frontend layout fix, and include focused frontend coverage for the overlap regression.

@sahare-mayur-0071 sahare-mayur-0071 force-pushed the fix-findings-layout-overlap-901 branch from 23c495e to c850d18 Compare June 21, 2026 04:35
@sahare-mayur-0071

Copy link
Copy Markdown
Contributor Author

I have updated this PR to only include the Findings layout fix and added the focused frontend unit tests for the layout regression as requested. The CI roll-up job has been removed from this branch and I will open a separate PR for it. Note: frontend-checks is waiting for status here because the roll-up job fix is no longer in this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci CI, tooling, or automation work area:frontend Frontend React/UI work level:intermediate 35 pts difficulty label for moderate contributor PRs type:bug Bug fix work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Search Filter Controls Overlap and Break Layout on Vulnerability Findings Page

2 participants