feat: validate mutually exclusive authentication fields for ssh_runner#1134
Open
deepsikha-dash wants to merge 1 commit into
Open
feat: validate mutually exclusive authentication fields for ssh_runner#1134deepsikha-dash wants to merge 1 commit into
deepsikha-dash wants to merge 1 commit into
Conversation
utksh1
requested changes
Jun 20, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Requesting changes. This adds a metadata-level mutually_exclusive declaration, but it does not add runtime input enforcement or tests proving ssh_runner rejects payloads that provide both password and private_key. Please add focused validator/runtime coverage for the mutual-exclusion contract before merge.
80ede2e to
73d7ad2
Compare
73d7ad2 to
f902942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Closes #848
Type of Change
How Has This Been Tested?
Verified the changes using:
python scripts/validate_plugins.py --plugin ssh_runner
python scripts/refresh_plugin_checksum.py --plugin ssh_runner
Validation completed successfully and the plugin checksum was confirmed to be up to date.
Checklist