fix(frontend): make theme toggle apply light mode#1220
Open
deepakvarma1536 wants to merge 1 commit into
Open
Conversation
44583c2 to
f20cdb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainafter PR fix light and dark theme toggle #1208 was closed as no longer merging cleanly.Closes #1089
Supersedes #1208
Verification
cd frontend && npm run typecheckcd frontend && npm run build -- --logLevel errorcd frontend && npm run testattempted locally, but local Node isv18.19.1while the repo recommends Node 20+; Vitest/jsdom fails before running tests withERR_REQUIRE_ESMfromhtml-encoding-snifferrequiring@exodus/bytes/encoding-lite.js.Notes