feat: add copy-trace action to Task Details error banner#1257
Open
Subramaniyajothi6 wants to merge 3 commits into
Open
feat: add copy-trace action to Task Details error banner#1257Subramaniyajothi6 wants to merge 3 commits into
Subramaniyajothi6 wants to merge 3 commits into
Conversation
Contributor
Author
|
Heads-up: the two red checks here are pre-existing breakage on This PR is frontend-only and all frontend checks pass.
The syntax error stops the app from importing, so If you'd like me to fix this, then I'll open an issue and work on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #830
Summary
Adds a one-click copy action for the error trace on the Task Details page, and fixes a pre-existing CI regression that surfaced while doing this frontend work.
#830 — copy-trace action
The failed-task error banner (
Critical_Execution_Fault) renderedtask.error_message(the error / stack trace) with no way to copy it. Raw failure output already had a copy action viaCopyToClipboardin the Raw Output tab, but the error trace did not.CopyToClipboard(shared component): added optionallabel(default"Copy Output") andtitleprops — backward compatible, so the existing Raw Output usage and its test are unchanged. Also disabled the button when there is nothing to copy (empty-state coherence, mirroring the existing "Copy ID" button).TaskDetails: added a "Copy Trace" button to the error banner header for one-click copy of the error trace.Incidental fix — Reports PDF button (unblocks frontend CI)
While running the frontend suite for this change,
frontend-checksfailed on pre-existingReportstests, not on this feature. Root cause: #1205 added a client-side "PDF" export button next to the server-side export button, so two buttons shared the accessible name "PDF" andgetByRole('button', { name: /^pdf$/i })matched two elements.frontend-checksruns the full unit suite, so this red-flagged every frontend PR (it only surfaces when frontend files change — backend-only pushes skip the job).aria-labelto the client-side PDF button so it no longer collides with the server-side export button. No visible UI change; also resolves the a11y issue of two identically named buttons in the same row.Verification
npm run typecheck— clean.npm run quality— passes.Notes
@utksh1 Please review this pr and if there is any suggestion please comment it down