Skip to content

docs: add help text for amass metadata#677

Merged
utksh1 merged 2 commits into
utksh1:mainfrom
Nairayadav:issue-522-amass-helptext
Jun 10, 2026
Merged

docs: add help text for amass metadata#677
utksh1 merged 2 commits into
utksh1:mainfrom
Nairayadav:issue-522-amass-helptext

Conversation

@Nairayadav

Copy link
Copy Markdown
Contributor

Fixes #522

Changes

  • Added help text for the Root Domain field in plugins/amass/metadata.json
  • Clarified the expected input format for Amass subdomain enumeration
  • Refreshed the plugin checksum

Verification

  • Updated metadata successfully
  • Refreshed checksum using scripts/refresh_plugin_checksum.py
  • Verified JSON structure remains valid

@utksh1 utksh1 added level:beginner 20 pts difficulty label for small beginner-friendly PRs type:docs Documentation work category bonus label area:plugins Scanner plugin metadata, schemas, or plugin runtime work labels Jun 8, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend tests are failing, so this cannot merge yet. Please rebase on latest main, regenerate the amass metadata checksum from the current plugin files, and make sure the parser output contract/backend test suite passes before requesting another review.

@Nairayadav Nairayadav force-pushed the issue-522-amass-helptext branch from 0067838 to d05cc88 Compare June 9, 2026 07:45
@Nairayadav

Copy link
Copy Markdown
Contributor Author

Thanks for the review.

I rebased the branch on the latest main and regenerated the checksum.

While investigating the CI failure, I found an inconsistency in the local validation tooling:

  • python scripts/refresh_plugin_checksum.py --plugin amass reports the checksum is already up to date.
  • python scripts/validate_plugins.py passes for all plugins, including amass.
  • python scripts/validate_plugin.py --plugin amass reports a checksum mismatch.

The PR only adds the requested help text and updates the checksum. Since the validators are producing conflicting results, the parser contract failure may be related to the current plugin validation/loading logic rather than the metadata change itself.

Could you advise whether there is an additional checksum regeneration or plugin registration step expected after the recent plugin checksum rollout changes?

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the latest push. Backend integration is still failing. Please keep this to amass help text only, avoid icon/format churn, refresh the checksum with the repo script, rebase on main, and rerun checks.

@utksh1 utksh1 added the gssoc:approved Admin validation: approved for GSSoC scoring label Jun 10, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after maintainer cleanup. The PR is now focused on plugin field help text and the affected plugin checksum validates locally.

@utksh1 utksh1 merged commit c9e8941 into utksh1:main Jun 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:plugins Scanner plugin metadata, schemas, or plugin runtime work gssoc:approved Admin validation: approved for GSSoC scoring level:beginner 20 pts difficulty label for small beginner-friendly PRs type:docs Documentation work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PLUGINS] Add field help text for amass metadata

2 participants