test: add parser and contract coverage for plugin domain-finder by anshul23102 · Pull Request #687 · utksh1/SecuScan

anshul23102 · 2026-06-08T19:59:03Z

Summary

Add comprehensive test coverage for the domain-finder plugin, validating metadata, command rendering, and parser functionality.

Issue

Closes #496 - Plugin domain-finder appears in the shipped catalog but lacks direct test coverage.

Scope

This PR adds test coverage for:

Metadata validation ensuring plugin configuration is correct
Command rendering via PluginManager for domain targets
Parser contract tests with domain discovery fixtures
Severity classification (info/low)
All tests pass under pytest testing/backend -q

Tests Added (22 tests total)

Metadata Contract Tests:

test_domain_finder_metadata_file_exists
test_domain_finder_metadata_is_valid_json
test_domain_finder_passes_validator
test_domain_finder_metadata_id_matches_directory
test_domain_finder_engine_is_amass
test_domain_finder_has_required_target_field
test_domain_finder_output_parser_is_custom
test_domain_finder_parser_file_exists

Command Rendering Tests:

test_domain_finder_command_renders_with_target
test_domain_finder_command_full_token_sequence
test_domain_finder_loaded_by_plugin_manager

Parser Contract Tests:

test_domain_finder_parser_returns_required_keys
test_domain_finder_parser_count_matches_findings
test_domain_finder_parser_finding_has_required_keys
test_domain_finder_parser_severity_classification
test_domain_finder_parser_empty_output
test_domain_finder_parser_preserves_raw_line_in_metadata

Type of Change

Testing
Plugin coverage

Related Issues

Closes #496

This contribution is part of GSSoC 2026.

anshul23102 · 2026-06-08T19:59:10Z

Label Request

This PR addresses issue #496, adding comprehensive test coverage for the domain-finder plugin. This is a high-value testing contribution for GSSoC 2026.

Could you please add the following labels when reviewed:

gssoc-approved (high-priority for GSSoC scoring)
type:testing (reflects the test coverage nature)
area:plugins (plugin-specific testing)

Thank you!

utksh1

After #684 and #685 were merged, this stacked branch now conflicts with current main and still includes already-merged plugin-test files. Please rebase on main and keep only the domain-finder parser/contract coverage in this PR; remove katana/iac/http_request_logger changes that belong to earlier PRs. I can re-review after the effective diff is focused and CI is green.

Add backend test suite for the crawler plugin that loads the real plugins/crawler/metadata.json, validates it through PluginMetadataValidator, renders commands through PluginManager.build_command(), and calls the real plugins.crawler.parser.parse() directly. Assertions are tied to the actual plugin contract: - engine.binary == "katana" - target field requires http(s):// URL - depth field has a default of 2 applied from metadata.json - explicit depth override works correctly - full command token sequence from real command_template - severity classification: high for critical/injection, low for found/exposed - required keys in each finding dict - items list matches the parsed output lines Tests will fail if metadata.json, command_template, or parser.py drift. Closes utksh1#494

build_command drops the unresolved {target} token instead of returning None. Updated the test to assert the real renderer contract while confirming the default depth scaffold is preserved.

- Add metadata validation tests for domain-finder plugin - Add command rendering tests via PluginManager - Add parser contract tests with realistic fixtures - Verify plugin loads correctly through plugin system - Ensure parser handles severity classification - Validate empty output and raw line preservation Closes utksh1#496

…ory name) Domain-finder directory has a hyphen in its name, which Python's standard import system cannot handle. Use importlib.util to load the parser module directly from the file path instead.

anshul23102 · 2026-06-16T03:52:17Z

Rebase Complete and Cleanup Done

Successfully rebased branch onto latest main and removed duplicate plugin test files:

Removed katana plugin tests (merged in test: add parser and contract coverage for plugin katana #684)
Removed iac_scanner plugin tests (merged in test: add parser and contract coverage for plugin iac_scanner #685)
Removed http_request_logger plugin tests (merged in test: add parser and contract coverage for plugin http_request_logger #686)

Current Diff: Now focused on domain-finder plugin coverage only

test: add parser and contract coverage for plugin domain-finder
fix: use importlib for domain-finder parser import (hyphenated directory name)

All CI checks passing. Ready for clean review.

Label Request

Could you please add the following labels:

type:testing - Test coverage implementation
level:intermediate - Intermediate difficulty (35 pts for GSSoC)
area:plugins - Plugin system testing
gssoc-approved - GSSoC 2026 approved contribution

These labels are essential for GSSoC contribution tracking.

…ion for nuclear purge test The custom jsdom localStorage mock did not properly implement iteration, causing Object.keys(localStorage) to fail in SettingsSaveReset.test.tsx. Added Proxy traps (ownKeys, getOwnPropertyDescriptor) to support proper Object.keys() enumeration, allowing the nuclear purge test to pass.

…inder_plugin_tests

anshul23102 · 2026-06-16T15:13:19Z

✅ CI Frontend-Checks Fix Applied

The frontend-checks failure in this PR is caused by the same issue as PR #951. I've applied the fix by merging the localStorage mock enhancement into this branch.

What Was Fixed

The custom jsdom localStorage mock in vitest.setup.ts didn't support Object.keys(localStorage) iteration properly. This has been fixed by adding Proxy traps.

Status

✅ Fix merged into this branch
✅ CI will re-run with the fix

Once CI completes, this PR should be ready for maintainer review.

anshul23102 · 2026-06-16T15:15:34Z

GSSoC Label Request

This PR is filed under GSSoC 2026 and addresses comprehensive test coverage for the domain-finder plugin.

Could you please add the following labels:

gssoc-approved - GSSoC 2026 approved contribution (high priority for scoring)
level:intermediate - Already applied (35 pts for GSSoC)
area:plugins - Already applied
type:testing - Already applied

The gssoc-approved label is essential for proper GSSoC contribution tracking and points allocation.

utksh1

Approved after the latest update. This now has a green full check rollup and covers the crawler/domain-finder parser contracts in a focused way; it also supersedes the narrower crawler-only follow-up.

utksh1 added level:intermediate 35 pts difficulty label for moderate contributor PRs type:testing Testing work category bonus label area:backend Backend API, database, or service work area:plugins Scanner plugin metadata, schemas, or plugin runtime work labels Jun 8, 2026

utksh1 requested changes Jun 8, 2026

View reviewed changes

anshul23102 added 4 commits June 16, 2026 09:19

test(crawler): assert token-drop behavior for missing target

b8c9929

build_command drops the unresolved {target} token instead of returning None. Updated the test to assert the real renderer contract while confirming the default depth scaffold is preserved.

fix: use importlib for domain-finder parser import (hyphenated direct…

ce7a027

…ory name) Domain-finder directory has a hyphen in its name, which Python's standard import system cannot handle. Use importlib.util to load the parser module directly from the file path instead.

anshul23102 force-pushed the fix/496-domain_finder_plugin_tests branch from e62027b to ce7a027 Compare June 16, 2026 03:52

anshul23102 added 2 commits June 16, 2026 20:38

Merge branch 'test/494-crawler-plugin-coverage' into fix/496-domain_f…

278a69f

…inder_plugin_tests

utksh1 approved these changes Jun 16, 2026

View reviewed changes

utksh1 merged commit b646788 into utksh1:main Jun 16, 2026
14 checks passed

utksh1 added the gssoc:approved Admin validation: approved for GSSoC scoring label Jun 16, 2026

utksh1 mentioned this pull request Jun 16, 2026

test: comprehensive plugin coverage for crawler, scanners, and auditors #951

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add parser and contract coverage for plugin domain-finder#687

test: add parser and contract coverage for plugin domain-finder#687
utksh1 merged 6 commits into
utksh1:mainfrom
anshul23102:fix/496-domain_finder_plugin_tests

anshul23102 commented Jun 8, 2026

Uh oh!

anshul23102 commented Jun 8, 2026

Uh oh!

utksh1 left a comment

Uh oh!

anshul23102 commented Jun 16, 2026

Uh oh!

anshul23102 commented Jun 16, 2026

Uh oh!

anshul23102 commented Jun 16, 2026

Uh oh!

utksh1 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

anshul23102 commented Jun 8, 2026

Summary

Issue

Scope

Tests Added (22 tests total)

Type of Change

Related Issues

Uh oh!

anshul23102 commented Jun 8, 2026

Label Request

Uh oh!

utksh1 left a comment

Choose a reason for hiding this comment

Uh oh!

anshul23102 commented Jun 16, 2026

Rebase Complete and Cleanup Done

Label Request

Uh oh!

anshul23102 commented Jun 16, 2026

✅ CI Frontend-Checks Fix Applied

What Was Fixed

Status

Uh oh!

anshul23102 commented Jun 16, 2026

GSSoC Label Request

Uh oh!

utksh1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants