[PLUGINS] Add metadata lint rules for missing field help text and ambiguous categories#717
Closed
Pcmhacker-piro wants to merge 6 commits into
Closed
[PLUGINS] Add metadata lint rules for missing field help text and ambiguous categories#717Pcmhacker-piro wants to merge 6 commits into
Pcmhacker-piro wants to merge 6 commits into
Conversation
added 3 commits
June 9, 2026 10:44
…ecycle - Add workflow.spec.ts with mocked API routes for GET/POST/DELETE /workflows - Cover creation via CreateSheet, manual run with queued task display, and delete with grid removal confirmation - Include full lifecycle scenario combining create, run, and delete - Set up API key in localStorage before navigation to bypass auth gate Fixes utksh1#563
…sed sidebar sync - Remove 100ms polling interval from AppShell that was polling localStorage to detect sidebar state changes - Sidebar now dispatches a 'sidebar-state-changed' CustomEvent on window whenever isExpanded changes - AppShell listens for the CustomEvent instead of polling - Preserves localStorage persistence for cross-tab scenarios - No external dependencies or context providers needed
…guous categories - Add VALID_CATEGORIES constant with all 12 recognized plugin categories - Add _check_category() validator that rejects unknown categories - Add help text lint check in _check_fields() to flag fields without user-facing description - Update valid test fixture to include help text on fields - Add comprehensive tests for both new lint rules - Document the new lint rules in PLUGINS.md under Plugin Validation Fixes utksh1#551
Contributor
Author
|
heyy @utksh1 |
utksh1
added
level:advanced
utksh1
requested changes
Jun 9, 2026
utksh1
left a comment
utksh1
left a comment
Owner
There was a problem hiding this comment.
This needs changes before merge. The formatting-hygiene check is failing and the PR is stacked with unrelated workflow/sidebar/plugin changes. Please rebase on main, split the metadata lint work into a focused PR, and make the new lint rules pass in CI.
test_valid_categories_accepted creates multiple plugin directories under the same tmp_path in a loop, causing FileExistsError without exist_ok=True.
Contributor
Author
|
hey @utksh1 |
Contributor
Author
|
heyy @utksh1 |
utksh1
requested changes
Jun 10, 2026
utksh1
left a comment
utksh1
left a comment
Owner
There was a problem hiding this comment.
Re-reviewed the latest update. This is still not focused enough to merge.
The PR still includes unrelated AppShell/Sidebar frontend changes alongside plugin-validator lint work. Please split those out and keep this PR limited to plugin metadata lint rules, fixture updates, and validator tests. Once the frontend files are removed and the validator-only diff stays green, I can re-review.
Pcmhacker-piro
added a commit
to Pcmhacker-piro/SecuScan
that referenced
this pull request
Jun 12, 2026
Add quality gates for plugin metadata to help contributors write consistent, user-friendly plugin definitions. - VALID_CATEGORIES set + _check_category() validation - Help text lint check (warning-level, non-blocking) - warnings list on ValidationResult for incremental compliance - Cross-owner BOLA regression tests Closes utksh1#551, Closes utksh1#717
Pcmhacker-piro
added a commit
to Pcmhacker-piro/SecuScan
that referenced
this pull request
Jun 12, 2026
Add quality gates for plugin metadata to help contributors write consistent, user-friendly plugin definitions. - VALID_CATEGORIES set + _check_category() validation - Help text lint check (warning-level, non-blocking) - warnings list on ValidationResult for incremental compliance - Cross-owner BOLA regression tests Closes utksh1#551, Closes utksh1#717
utksh1
pushed a commit
that referenced
this pull request
Jun 12, 2026
* feat(plugins): add metadata lint rules Add quality gates for plugin metadata to help contributors write consistent, user-friendly plugin definitions. - VALID_CATEGORIES set + _check_category() validation - Help text lint check (warning-level, non-blocking) - warnings list on ValidationResult for incremental compliance - Cross-owner BOLA regression tests Closes #551, Closes #717 * feat(plugins): add metadata lint rules Add quality gates for plugin metadata to help contributors write consistent, user-friendly plugin definitions. - VALID_CATEGORIES set + _check_category() validation - Help text lint check (warning-level, non-blocking) - warnings list on ValidationResult for incremental compliance - Cross-owner BOLA regression tests Closes #551, Closes #717
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing in favor of the clean PR #789 which contains only the plugin metadata lint changes (no unrelated AppShell/e2e commits).