[PLUGINS] Clarify overlap between subfinder, subdomain-finder, and subdomain_discovery#719
Closed
Pcmhacker-piro wants to merge 6 commits into
Closed
[PLUGINS] Clarify overlap between subfinder, subdomain-finder, and subdomain_discovery#719Pcmhacker-piro wants to merge 6 commits into
Pcmhacker-piro wants to merge 6 commits into
Conversation
added 4 commits
June 9, 2026 10:44
…ecycle - Add workflow.spec.ts with mocked API routes for GET/POST/DELETE /workflows - Cover creation via CreateSheet, manual run with queued task display, and delete with grid removal confirmation - Include full lifecycle scenario combining create, run, and delete - Set up API key in localStorage before navigation to bypass auth gate Fixes utksh1#563
…sed sidebar sync - Remove 100ms polling interval from AppShell that was polling localStorage to detect sidebar state changes - Sidebar now dispatches a 'sidebar-state-changed' CustomEvent on window whenever isExpanded changes - AppShell listens for the CustomEvent instead of polling - Preserves localStorage persistence for cross-tab scenarios - No external dependencies or context providers needed
…guous categories - Add VALID_CATEGORIES constant with all 12 recognized plugin categories - Add _check_category() validator that rejects unknown categories - Add help text lint check in _check_fields() to flag fields without user-facing description - Update valid test fixture to include help text on fields - Add comprehensive tests for both new lint rules - Document the new lint rules in PLUGINS.md under Plugin Validation Fixes utksh1#551
…r, and subdomain_discovery - Remove subdomain-finder (100% duplicate of subfinder — same binary, same command template, same fields, no unique value) - Differentiate subfinder as quick/minimal passive enumeration with a single input - Differentiate subdomain_discovery as comprehensive/configurable enumeration with thread and source coverage tuning - Refresh checksums for both modified plugins - Update PLUGINS.md catalog to reflect the final taxonomy Fixes utksh1#543
Contributor
Author
|
heyy @utksh1 |
utksh1
added
level:beginner
utksh1
requested changes
Jun 9, 2026
utksh1
left a comment
utksh1
left a comment
Owner
There was a problem hiding this comment.
This needs changes before merge. The current diff is stacked with unrelated workflow/sidebar/lint changes instead of being limited to subdomain plugin clarification. Please rebase on main and resubmit only the focused metadata/docs changes for subfinder/subdomain-finder/subdomain_discovery.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✦ Description
Consolidated and clarified the three overlapping subdomain discovery plugins into two clearly differentiated plugins with distinct roles.
Changes
subdomain-finder— 100% duplicate ofsubfinder(same binary, command template, fields).subfinder— Quick passive enumeration with minimal config. Just provide a root domain.subdomain_discovery— Comprehensive configurable enumeration with thread/source tuning and presets.subfindersubdomain_discoverysubdomain_takeoverFixes #543
⟡ Type of Change
✦ Checklist