fix: help metadata update#726
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the dnsx plugin metadata to improve UI/UX text and adjust displayed icon, with a corresponding checksum update.
Changes:
- Switched the plugin icon representation from a Unicode escape to a literal emoji.
- Added a
helpdescription to theDomaininput parameter. - Updated the metadata
checksumvalue.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "license": "MIT", | ||
| "icon": "\ud83d\udd0e", | ||
| "icon": "🔎", |
| "system_packages": [] | ||
| }, | ||
| "checksum": "8f1a5ecf2f4e2192010470c00853682ab7f70714325cdc8d59c8000a1598f44a" | ||
| "checksum": "49c0fa05387f10729791047d44fb12f2dd6770add1a5d92d701ae4176417ea88" |
Maria-Niya
left a comment
There was a problem hiding this comment.
Hi, I am not understanding why the backend integration test is failing, i have added the 'help' metadata and have updated the checksum. Any tips on what should I do next?
utksh1
left a comment
There was a problem hiding this comment.
Thanks. This is close but not ready: backend integration is failing, and the diff changes the icon while the issue only needs dnsx field help text plus the correct checksum. Please remove unrelated icon churn, refresh the checksum from the repo script, rebase on main, and rerun checks.
|
I have done whatever you have asked and only changed the help text and refreshed the checksum but the backend is still failing. |
utksh1
left a comment
There was a problem hiding this comment.
Approved after maintainer cleanup. The PR is now focused on plugin field help text and the affected plugin checksum validates locally.
Description
Added missing
helptext to thetargetfield in thednsxplugin metadata (plugins/dnsx/metadata.json). The new copy clearly explains the expected input format and operator intent to the user, preventing confusion when the plugin form is rendered in the UI. Additionally, refreshed the plugin checksum to ensure validation passes.Related Issues
Closes #524
Type of Change
How Has This Been Tested?
plugins/dnsx/metadata.jsonlocally.python scripts/refresh_plugin_checksum.py --plugin dnsxpython scripts/validate_plugins.py(Validation passed with no errors).Checklist