Skip to content

fix: help metadata update#726

Merged
utksh1 merged 4 commits into
utksh1:mainfrom
Maria-Niya:main
Jun 10, 2026
Merged

fix: help metadata update#726
utksh1 merged 4 commits into
utksh1:mainfrom
Maria-Niya:main

Conversation

@Maria-Niya

Copy link
Copy Markdown
Contributor

Description

Added missing help text to the target field in the dnsx plugin metadata (plugins/dnsx/metadata.json). The new copy clearly explains the expected input format and operator intent to the user, preventing confusion when the plugin form is rendered in the UI. Additionally, refreshed the plugin checksum to ensure validation passes.

Related Issues

Closes #524

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ x ] Documentation update

How Has This Been Tested?

  1. Modified plugins/dnsx/metadata.json locally.
  2. Ran the checksum refresh script successfully: python scripts/refresh_plugin_checksum.py --plugin dnsx
  3. Ran the validation script to ensure the new checksum and syntax are correct: python scripts/validate_plugins.py (Validation passed with no errors).

Checklist

  • [ x ] My code follows the code style of this project.
  • [ x ] I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • [ x ] I have made corresponding changes to the documentation.
  • [ x ] My changes generate no new warnings.

Copilot AI review requested due to automatic review settings June 9, 2026 07:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the dnsx plugin metadata to improve UI/UX text and adjust displayed icon, with a corresponding checksum update.

Changes:

  • Switched the plugin icon representation from a Unicode escape to a literal emoji.
  • Added a help description to the Domain input parameter.
  • Updated the metadata checksum value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

},
"license": "MIT",
"icon": "\ud83d\udd0e",
"icon": "🔎",
Comment thread plugins/dnsx/metadata.json Outdated
"system_packages": []
},
"checksum": "8f1a5ecf2f4e2192010470c00853682ab7f70714325cdc8d59c8000a1598f44a"
"checksum": "49c0fa05387f10729791047d44fb12f2dd6770add1a5d92d701ae4176417ea88"

@Maria-Niya Maria-Niya left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I am not understanding why the backend integration test is failing, i have added the 'help' metadata and have updated the checksum. Any tips on what should I do next?

@utksh1 utksh1 added level:beginner 20 pts difficulty label for small beginner-friendly PRs type:docs Documentation work category bonus label area:plugins Scanner plugin metadata, schemas, or plugin runtime work labels Jun 9, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is close but not ready: backend integration is failing, and the diff changes the icon while the issue only needs dnsx field help text plus the correct checksum. Please remove unrelated icon churn, refresh the checksum from the repo script, rebase on main, and rerun checks.

@Maria-Niya

Copy link
Copy Markdown
Contributor Author

I have done whatever you have asked and only changed the help text and refreshed the checksum but the backend is still failing.

@utksh1 utksh1 added the gssoc:approved Admin validation: approved for GSSoC scoring label Jun 10, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after maintainer cleanup. The PR is now focused on plugin field help text and the affected plugin checksum validates locally.

@utksh1 utksh1 merged commit dba25ac into utksh1:main Jun 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:plugins Scanner plugin metadata, schemas, or plugin runtime work gssoc:approved Admin validation: approved for GSSoC scoring level:beginner 20 pts difficulty label for small beginner-friendly PRs type:docs Documentation work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PLUGINS] Add field help text for dnsx metadata

3 participants