Skip to content

Add command execution and cancellation logging#896

Open
poojaarabati wants to merge 5 commits into
utksh1:mainfrom
poojaarabati:fix-time-notification-710
Open

Add command execution and cancellation logging#896
poojaarabati wants to merge 5 commits into
utksh1:mainfrom
poojaarabati:fix-time-notification-710

Conversation

@poojaarabati

Copy link
Copy Markdown

Description

Added logging statements in BaseScanner to improve visibility of command execution and cancellation events.

Related Issues

Fixes #710

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Reviewed code changes manually.
  • Verified logging statements are added for command completion and command cancellation paths.

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@poojaarabati

Copy link
Copy Markdown
Author

Hi, I have implemented timeout exception handling, retry logic and logging for issue #710. The CI is failing on backend-lint and frontend-checks. I'm a beginner contributor and don't have local environment set up to fix linting issues. Could you please guide me on what specific changes are needed? I'm eager to learn and fix this!

@utksh1 utksh1 added level:intermediate 35 pts difficulty label for moderate contributor PRs type:bug Bug fix work category bonus label area:backend Backend API, database, or service work labels Jun 13, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This cannot merge while required CI is failing.

Current failing checks include Fresh-clone smoke test (Ubuntu), backend-lint, and frontend-checks. Please fix those failures and keep the patch focused on command execution/cancellation logging so it can be reviewed cleanly.

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecking after the latest indentation fix: this is still blocked.

Required checks are still failing, including Fresh-clone smoke test (Ubuntu), formatting-hygiene, and backend-lint. Please fix those failures before this command execution/cancellation logging change can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend Backend API, database, or service work level:intermediate 35 pts difficulty label for moderate contributor PRs type:bug Bug fix work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Scan timeout causes silent failures without user notification

2 participants