Skip to content

Fix: IPv6 address parsing bypass in validate_command_network_egress #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poojaarabati wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: IPv6 address parsing bypass in validate_command_network_egress #918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions backend/secuscan/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ def resolve_and_validate_target(url: str) -> Tuple[bool, str]:

# Resolve hostname to IPs
try:
resolved = socket.getaddrinfo(hostname, port or 443, proto=socket.IPPROTO_TCP)
resolved f = socket.getaddrinfo(hostname, port or 443, proto=socket.IPPROTO_TCP)
except OSError:
return False, f"Could not resolve hostname: {hostname}"

Expand Down Expand Up @@ -642,12 +642,17 @@ def validate_command_network_egress(command: list[str], safe_mode: bool, plugin_
if not candidate:
continue

# Clean port suffix if present (e.g. "example.com:80" or "10.0.0.1:8080")
if ":" in candidate and not candidate.startswith("["):
parts = candidate.rsplit(":", 1)
if parts[1].isdigit():
candidate = parts[0]

# Check for IPv6 first — colon handling differs
try:
ipaddress.IPv6Address(candidate)
is_ip = True
except ipaddress.AddressValueError:
pass

if not is_ip and ":" in candidate and not candidate.startswith("["):
parts = candidate.rsplit(":", 1)
if parts[1].isdigit():
candidate = parts[0]
is_ip = False
try:
# Try to parse as IP/CIDR (handles single IP and subnet validation)
Expand Down
Loading