Skip to content

[TASK] Add keyboard navigation tests for report comparison view #923 #943

Closed
Suji2007hub wants to merge 8 commits into
utksh1:mainfrom
Suji2007hub:main
Closed

[TASK] Add keyboard navigation tests for report comparison view #923 #943
Suji2007hub wants to merge 8 commits into
utksh1:mainfrom
Suji2007hub:main

Conversation

@Suji2007hub

Copy link
Copy Markdown

Summary:

Added a focused unit regression test for frontend/src/pages/ReportCompare.tsx to ensure keyboard focus/context is retained while scrolling within the findings list (“New findings” section).
This covers the missing sticky-context behavior contract and runs in the existing frontend unit test CI job.
No functional UI changes (only an EOF newline fix in frontend/src/pages/ReportCompare.tsx).
Changes:

frontend/testing/unit/pages/ReportCompare.test.tsx
New test: “keeps context while scrolling within a findings list (sticky header regression guard)”
Verifies the “New findings” section remains present and document.activeElement stays stable after scroll.
CI impact:

Executes under the existing frontend unit tests (npm run test) as part of the current CI workflow.

@utksh1 utksh1 added level:intermediate 35 pts difficulty label for moderate contributor PRs type:testing Testing work category bonus label area:frontend Frontend React/UI work labels Jun 15, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ReportCompare keyboard-navigation tests. This cannot merge while required checks are failing.

Current failures include Fresh-clone smoke test (Ubuntu), Build frontend image, frontend-checks, and backend-integration. Please fix CI and remove unrelated frontend dependency churn if it is not directly needed for these tests.

@Suji2007hub

Copy link
Copy Markdown
Author

@utksh1 review now

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. This still is not ready to merge as a focused keyboard-navigation test PR: the branch contains unrelated dependency/package changes, including package-lock churn/deletion history and a Vite version change, plus an unnecessary ReportCompare source newline change. Please rebase on current main and keep the diff limited to the ReportCompare test coverage only, with frontend checks green.

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not ready to merge. This PR mixes CI workflow edits, frontend Docker/nginx/package changes, setup.sh changes, and ReportCompare test work in one branch. Even though the latest rollup is green, the scope is too broad for a keyboard-navigation test PR. Please split the runtime/CI/package changes from the ReportCompare test change.

@utksh1 utksh1 added the gssoc:invalid Admin validation: invalid for GSSoC scoring label Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Frontend React/UI work gssoc:invalid Admin validation: invalid for GSSoC scoring level:intermediate 35 pts difficulty label for moderate contributor PRs type:testing Testing work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants