[TASK] Add keyboard navigation tests for report comparison view #923 #943
[TASK] Add keyboard navigation tests for report comparison view #923 #943Suji2007hub wants to merge 8 commits into
Conversation
>> utksh1#923 >> Edit title >> Closed
utksh1
left a comment
There was a problem hiding this comment.
Thanks for the ReportCompare keyboard-navigation tests. This cannot merge while required checks are failing.
Current failures include Fresh-clone smoke test (Ubuntu), Build frontend image, frontend-checks, and backend-integration. Please fix CI and remove unrelated frontend dependency churn if it is not directly needed for these tests.
|
@utksh1 review now |
utksh1
left a comment
There was a problem hiding this comment.
Thanks for the update. This still is not ready to merge as a focused keyboard-navigation test PR: the branch contains unrelated dependency/package changes, including package-lock churn/deletion history and a Vite version change, plus an unnecessary ReportCompare source newline change. Please rebase on current main and keep the diff limited to the ReportCompare test coverage only, with frontend checks green.
utksh1
left a comment
There was a problem hiding this comment.
Still not ready to merge. This PR mixes CI workflow edits, frontend Docker/nginx/package changes, setup.sh changes, and ReportCompare test work in one branch. Even though the latest rollup is green, the scope is too broad for a keyboard-navigation test PR. Please split the runtime/CI/package changes from the ReportCompare test change.
Summary:
Added a focused unit regression test for frontend/src/pages/ReportCompare.tsx to ensure keyboard focus/context is retained while scrolling within the findings list (“New findings” section).
This covers the missing sticky-context behavior contract and runs in the existing frontend unit test CI job.
No functional UI changes (only an EOF newline fix in frontend/src/pages/ReportCompare.tsx).
Changes:
frontend/testing/unit/pages/ReportCompare.test.tsx
New test: “keeps context while scrolling within a findings list (sticky header regression guard)”
Verifies the “New findings” section remains present and document.activeElement stays stable after scroll.
CI impact:
Executes under the existing frontend unit tests (npm run test) as part of the current CI workflow.