feat(nodex-api): upgrade Node-API headers and add v9/v10 surface#6
Conversation
Agent-Logs-Url: https://github.com/uuhan/nodex/sessions/e3484bea-e3ba-4ff3-9fc3-4032cf875aa6 Co-authored-by: uuhan <3286111+uuhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/uuhan/nodex/sessions/e3484bea-e3ba-4ff3-9fc3-4032cf875aa6 Co-authored-by: uuhan <3286111+uuhan@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4bbf084adb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| result: *mut napi_value, | ||
| ) -> NapiStatus; | ||
| } | ||
| #[cfg(any(feature = "v9", feature = "v10"))] |
There was a problem hiding this comment.
The new binding is exposed for v9 via #[cfg(any(feature = "v9", feature = "v10"))], but the updated node-api-headers snapshot this commit points to (663251b...) declares node_api_create_buffer_from_arraybuffer only for NAPI_VERSION >= 10. Exposing it in v9 lets downstream code compile against a symbol that is outside the advertised API level and can fail when loaded/run against a v9-capable runtime.
Useful? React with 👍 / 👎.
Agent-Logs-Url: https://github.com/uuhan/nodex/sessions/4602fd2d-4fba-487b-b4e9-bbc138a6e588 Co-authored-by: uuhan <3286111+uuhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/uuhan/nodex/sessions/70b00b61-2eee-48bb-a88d-e7d8e8b353e9 Co-authored-by: uuhan <3286111+uuhan@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.