Skip to content

feat(uucore): support signals feature on Haiku - #14603

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:uucore-feature-signals-haiku
Open

xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:uucore-feature-signals-haiku

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Add Haiku to the platforms supporting the signals feature and define its signal set from posix/signal.h.

RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std \
  -p uucore --features signals --all-targets \
  --target x86_64-unknown-haiku
Shell script used to generate ALL_SIGNALS.
curl -fsSL
'https://raw.githubusercontent.com/haiku/haiku/refs/heads/master/headers/posix/signal.h'
|
awk '/^[[:space:]]*#define[[:space:]]+SIG[A-Z0-9_]+[[:space:]]+[0-9]+/ {
    name=$2
    sub(/^SIG/, "", name)
    sigs[$3]=name
}
END {
    print "EXIT"
    for (i=1; i<=32; i++) print sigs[i]
}'

@xtqqczze
xtqqczze force-pushed the uucore-feature-signals-haiku branch from 1b2a1ce to da0b5ac Compare September 16, 2026 12:33
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/retry (passes in this run but fails in the 'main' branch)

@xtqqczze
xtqqczze force-pushed the uucore-feature-signals-haiku branch from da0b5ac to aba1283 Compare September 16, 2026 13:20
@xtqqczze
xtqqczze marked this pull request as ready for review September 16, 2026 13:44
@xtqqczze
xtqqczze force-pushed the uucore-feature-signals-haiku branch 4 times, most recently from 6e34620 to 193bfe2 Compare September 18, 2026 16:30
@codspeed

codspeed Bot commented Sep 18, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 13.18%

❌ 3 regressed benchmarks
✅ 370 untouched benchmarks
⏩ 50 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation od_default 511.8 ms 601.3 ms -14.89%
Simulation od_chars 831.2 ms 948.2 ms -12.34%
Simulation od_hex_bytes 870.1 ms 991.8 ms -12.28%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:uucore-feature-signals-haiku (9ceb7ef) with main (a3b3a24)2

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (17f1a5d) during the generation of this report, so a3b3a24 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@xtqqczze
xtqqczze force-pushed the uucore-feature-signals-haiku branch from 193bfe2 to 87a0513 Compare September 18, 2026 21:56
@xtqqczze xtqqczze changed the title uucore: support signals feature for haiku feat(uucore): support signals feature on Haiku Sep 18, 2026
@xtqqczze
xtqqczze force-pushed the uucore-feature-signals-haiku branch from 87a0513 to f793d9e Compare September 18, 2026 21:57
@xtqqczze

Copy link
Copy Markdown
Contributor Author

```sh
RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std \
  -p uucore --features signals --all-targets \
  --target x86_64-unknown-haiku
```
@xtqqczze
xtqqczze force-pushed the uucore-feature-signals-haiku branch from f793d9e to 9ceb7ef Compare September 18, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant