Conversation
Merging this PR will degrade performance by 13.72%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | rm_single_file |
105.1 ms | 135.5 ms | -22.44% |
| ❌ | Simulation | factor_multiple_u64s[2] |
68.3 ms | 71.1 ms | -4.01% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing krosci:fix/posixly-correct-arg-parsing (8a8664d) with main (b60091b)2
Footnotes
-
50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(41c3451) during the generation of this report, so b60091b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
GNU testsuite comparison: |
504c205 to
8a8664d
Compare
| k == ContextKind::InvalidArg && v == &ContextValue::String("[template]".into()) | ||
| }) => | ||
| { | ||
| UUsageError::new(1, translate!("mktemp-error-too-many-templates")) |
|
The perf regression is due to checking the envvar, nothing that we can avoid, sadly. |
When POSIXLY_CORRECT is present in the environment, option processing must stop at the first non-option argument, treating all subsequent arguments as operands. This patch introduces argument preparation in uucore's clap localization and argument parsing entry points to insert the end-of-options separator before the first positional operand while preserving GNU compatibility for join and pr. Comprehensive unit and integration tests have been added across utilities to prevent regression.
Fixes #14621