tests/od: fix two tests on big-endian hosts - #14671
Merged
Merged
Conversation
test_suppress_duplicates and test_od_options_after_filename dump multi-byte units (-x, -O, -t x2) and compare the result against little-endian expected output without selecting a byte order. They fail on big-endian hosts, where od correctly defaults to the native order: expected: " 1c68 fdbb\n" actual: " 681c bbfd\n" Pass --endian=little like the other tests in this file do. In test_od_options_after_filename the option goes after the file name, in keeping with what that test exercises. Found on FreeBSD/powerpc64.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_suppress_duplicates and test_od_options_after_filename dump
multi-byte units (-x, -O, -t x2) and compare the result against
little-endian expected output without selecting a byte order. They
fail on big-endian hosts, where od correctly defaults to the native
order:
expected: " 1c68 fdbb\n"
actual: " 681c bbfd\n"
Pass --endian=little like the other tests in this file do. In
test_od_options_after_filename the option goes after the file name, in
keeping with what that test exercises.
Found on FreeBSD/powerpc64.