sed: keep script position for errors at end of script - #579
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
- Coverage 83.87% 83.83% -0.05%
==========================================
Files 14 14
Lines 6977 6984 +7
Branches 407 407
==========================================
+ Hits 5852 5855 +3
- Misses 1121 1125 +4
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
GNU sed testsuite comparison: |
16bb414 to
43681a9
Compare
Merging this PR will degrade performance by 5.26%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | number_fix |
1.1 s | 1.3 s | -13.81% |
| ⚡ | access_log_subst |
2.4 s | 2.3 s | +4.13% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing sylvestre:script-end-position (43681a9) with main (72ed709)
An error found once the script is exhausted, like an unterminated command, lost its location and was reported as
:0:N. Keep the last input name and line number, so it points at the script argument or file line, as GNU sed does.Split out of #576.