Skip to content

clippy: fix warnings from assert_is_empty lint - #588

Open
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:clippy_assert_is_empty
Open

cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:clippy_assert_is_empty

Conversation

@cakebaker

Copy link
Copy Markdown
Contributor

This PR fixes three warnings from the assert_is_empty lint that show up with Rust 1.99.

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.86%. Comparing base (95804a2) to head (27bd13d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files          14       14           
  Lines        7203     7203           
  Branches      424      424           
=======================================
  Hits         6041     6041           
  Misses       1157     1157           
  Partials        5        5           
Flag Coverage Δ
macos_latest 84.98% <ø> (ø)
ubuntu_latest 85.17% <ø> (ø)
windows_latest 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Oct 1, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 3.34%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 8 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ access_log_no_subst 1.1 s 1.1 s +3.45%
⚡ access_log_all_del 1.2 s 1.1 s +3.34%
⚡ access_log_no_del 1.1 s 1.1 s +3.24%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing cakebaker:clippy_assert_is_empty (27bd13d) with main (95804a2)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant