ci: use an absolute LLVM_PROFILE_FILE path so coverage includes the sed binary - #591
Open
DePasqualeOrg wants to merge 1 commit into
Open
DePasqualeOrg wants to merge 1 commit into
DePasqualeOrg wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
===========================================
+ Coverage 83.86% 94.82% +10.95%
===========================================
Files 14 14
Lines 7203 7203
Branches 424 424
===========================================
+ Hits 6041 6830 +789
+ Misses 1157 372 -785
+ Partials 5 1 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DePasqualeOrg
marked this pull request as ready for review
October 2, 2026 16:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration tests run the sed binary through
uutests, which starts each command in a temporary directory that is deleted when the test ends. BecauseLLVM_PROFILE_FILEis a relative path, every run of the binary writes its.profrawfile into that directory, and its coverage is lost. Only the unit tests, which run in the workspace, are counted.As a result, Codecov reports
src/sed/processor.rsat about 28%. Code that many tests run, such as theq,Qand=commands and the automatic printing of the pattern space, is shown as never executed, andcodecov/patchfails on most changes to command behavior.This PR anchors the path to the workspace, so the files survive the test and grcov finds them. uutils/grep#5 made the same change, which raised its reported coverage from 0% to about 96%.