Repository navigation
sed: discard text queued by a, r and R on Q, as GNU sed does - #594
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 14 14
Lines 7212 7213 +1
Branches 428 428
=======================================
+ Hits 6839 6840 +1
Misses 372 372
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will regress 1 benchmark
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
DePasqualeOrg
force-pushed
the
fix-q-discards-appends
branch
from
October 4, 2026 10:19
8374812 to
840add2
Compare
DePasqualeOrg
marked this pull request as ready for review
October 4, 2026 10:40
sylvestre
reviewed
Oct 5, 2026
| } | ||
|
|
||
| /// `Q` discards text queued by `a`, `r` and `R`, as GNU sed does. | ||
| #[test] |
Contributor
There was a problem hiding this comment.
please use the test_ prefix like the other tests
DePasqualeOrg
force-pushed
the
fix-q-discards-appends
branch
from
October 5, 2026 08:20
840add2 to
f2ac3ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qquits without printing the pattern space, and GNU sed also discards any text thata,rorRqueued in the same cycle. uutils sed writes that text:printf 'x\n' | sed -e 'a A' -e QprintsA, while GNU sed prints nothing. This PR clears the queue onQ.qstill writes queued text, as in GNU sed.