fix(windows): rollback failed tunnel configuration - #120
Closed
weix37469-web wants to merge 1 commit into
Closed
weix37469-web wants to merge 1 commit into
weix37469-web wants to merge 1 commit into
Conversation
Author
|
Closing this PR so I can rework the change from a clean branch and walk through the fix and tests step by step before resubmitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tunnel configureWhy
agentdock tunnel configurecurrently persists the replacement Token / URL / mode before the new Tunnel is proven ready. If a later step fails (for example,cloudflaredrejects the replacement configuration), the command returns an error but leaves partially committed state on disk.That means a failed configuration attempt can destroy the last committed configuration instead of behaving transactionally. The installer/update path already has rollback semantics; the direct Windows Tunnel configure path did not.
Tests
mainand pass with this changego test ./... -count=1 -timeout=3mgo vet ./...go build ./cmd/agentdockgit diff --check