Open
Conversation
s-naik
requested review from
JonShim,
gdgould,
hydrofluorich and
roselynh100
as code owners
created static database based on a related csv file with: id, first name, last name, email, faculty, member type, and watiam. the enum values are not used in the database (the variable names are used), but if we need the enum values instead then that's a quick fix
Contributor
There was a problem hiding this comment.
Can we add some more name and email formats? i.e. multi-word and hyphenated names (first and last), emails with numbers, non-uwaterloo emails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
created static database based on a related csv file with: id, first name, last name, email, faculty, member type, and watiam.
the enum values are not used in the database (the variable names are used), but if we need the enum values instead then that's a quick fix