scale engine: Try harder to find a proper step size for minor ticks - #327
Open
peter-ha wants to merge 1 commit into
Open
scale engine: Try harder to find a proper step size for minor ticks#327peter-ha wants to merge 1 commit into
peter-ha wants to merge 1 commit into
Conversation
If the maxSteps don't fit into the interval, we immediately returned a base value. However, we could try more often with less steps before falling back to that base value, giving better results when the original steps value doesnt' fit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the maxSteps don't fit into the interval, we immediately returned a base value. However, we could try more often with less steps before falling back to that base value, giving better results when the original steps value doesnt' fit.