fix issue with building with both examples and playground disabled - #412
Open
ovenpasta wants to merge 1 commit into
Open
fix issue with building with both examples and playground disabled#412ovenpasta wants to merge 1 commit into
ovenpasta wants to merge 1 commit into
Conversation
uwerat
reviewed
Jul 18, 2024
| message(FATAL_ERROR "Couldn't find any Qt package !") | ||
| endif() | ||
|
|
||
| find_package(Qt${QT_VERSION_MAJOR} REQUIRED COMPONENTS Quick) |
Owner
There was a problem hiding this comment.
There is already a find_package( ... Quick) at the beginning of qsk_setup_Qt.
Could you please find out why it is not working in your case ?
Contributor
Author
There was a problem hiding this comment.
Yes it is strange, and the patch effectively fixes the issue in my case. I can reproduce both on windows / vcpkg / qt 6 and with Arch Linux / Qt 6.7.1.
I've found this:
https://doc.qt.io/qt-6/cmake-qt5-and-qt6-compatibility.html#supporting-older-qt-5-versions
They suggest that for older qt 5 versions should call find_package twice, one with the QT + NAMES and the second with the effective version. In my case it is needed even with Qt6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building qskinny with both
-DBUILD_EXAMPLES=OFFand-DBUILD_PLAYGROUND=OFF, cmake cannot find the QtQuick library. Probably it gets pulled as part of QuickWidgets and WebEngine