Open
Conversation
AaronYoung5
reviewed
Nov 19, 2023
workspace/src/common/launch/art_oak_launch/launch/art_oak.launch.py
Outdated
Show resolved
Hide resolved
workspace/src/common/launch/art_oak_launch/launch/art_oak.launch.py
Outdated
Show resolved
Hide resolved
Contributor
|
Gonna hold off on reviewing till we discuss in #116 |
Contributor
Author
|
oops |
Contributor
|
dollar |
Contributor
Author
is there a way for me to change the name of this branch while leaving the PR open? |
Contributor
|
ya just push to the new branch name and then update this PR with that branch |
AaronYoung5
approved these changes
Jan 30, 2024
| # Composability | ||
| # ------------- | ||
|
|
||
| AddLaunchArgument(ld, "container", "") |
Contributor
There was a problem hiding this comment.
only comment is adding spaces above and below this haha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't actually do anything different than
art_dev_metaatm (and I doubt this actually works bcs some stuff was removed). Just adding the framework for oak to be able to launch before adding in specific nodes.