Skip to content

[maintenance] Remove unnecessary base class in onedal.linear_model.LogisticRegression#3218

Open
icfaust wants to merge 1 commit into
uxlfoundation:mainfrom
icfaust:dev/log_reg_remove
Open

[maintenance] Remove unnecessary base class in onedal.linear_model.LogisticRegression#3218
icfaust wants to merge 1 commit into
uxlfoundation:mainfrom
icfaust:dev/log_reg_remove

Conversation

@icfaust
Copy link
Copy Markdown
Contributor

@icfaust icfaust commented May 29, 2026

Description

Continuing to cut things down, this abstraction is also unnecessary and does not match other implementations.


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
azure 76.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
onedal/linear_model/logistic_regression.py 28.35% <100.00%> (-2.63%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@icfaust
Copy link
Copy Markdown
Contributor Author

icfaust commented May 29, 2026

/intelci: run

@icfaust icfaust marked this pull request as ready for review May 29, 2026 19:32
fit_intercept=True,
solver="newton-cg",
max_iter=100,
algorithm="dense_batch",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should * and/or **kwargs still be included in the init?

@ethanglaser ethanglaser requested a review from avolkov-intel May 29, 2026 20:45
@david-cortes-intel
Copy link
Copy Markdown
Contributor

@icfaust Title say onedal.cluster.LogisticRegression. Please fix as it will go into the commit name.

@icfaust
Copy link
Copy Markdown
Contributor Author

icfaust commented Jun 2, 2026

@david-cortes-intel good catch. Was replicating a bit of that KMeans PR. Will change.

@icfaust icfaust changed the title [maintenance] Remove unnecessary base class in onedal.cluster.LogisticRegression [maintenance] Remove unnecessary base class in onedal.linear_model.LogisticRegression Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants