Skip to content

[CI] Make test deselection logic more extensible#3250

Draft
icfaust wants to merge 2 commits into
uxlfoundation:mainfrom
icfaust:dev/parsing_improvements
Draft

[CI] Make test deselection logic more extensible#3250
icfaust wants to merge 2 commits into
uxlfoundation:mainfrom
icfaust:dev/parsing_improvements

Conversation

@icfaust
Copy link
Copy Markdown
Contributor

@icfaust icfaust commented Jun 4, 2026

Description

Just removing some ugly logic. This should make extensibility easier rather than a large if statement addition, just defining a new kwarg with the matchin yaml section name (all around the argparse instead).


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
azure 77.64% <ø> (ø)
github ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant