update package dependencies#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the project's build infrastructure and dependency management by updating package dependencies, simplifying the installation process, removing the Cstruct dependency in favor of direct string operations, and upgrading the dune language version.
Key changes include:
- Migration from Cstruct to native string operations for CSRF token handling
- Addition of pin-depends for opium, rock, and letters packages
- Removal of .opam.locked files in favor of simpler dependency management
- Update of dune language from 2.7 to 3.0 for improved formatting consistency
- Removal of unused Node.js from the main devcontainer (kept in template)
- Upgrade to OCaml 5.x (5.3 in CI, 5.4 in Dockerfiles) and opam 2.3
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sihl/src/web_csrf.ml | Replaced Cstruct-based token handling with native string operations |
| sihl/test/web_csrf.ml | Updated tests to use string-based token operations instead of Cstruct |
| sihl/src/dune | Removed cstruct dependency and reformatted libraries multiline |
| sihl/test/dune | Reformatted executables and libraries multiline for consistency |
| sihl.opam | Added alphabetically sorted dependencies, removed cstruct, added dev-setup tools |
| sihl.opam.template | Added pin-depends for opium and rock packages |
| sihl.opam.locked | Removed locked file in favor of flexible dependency resolution |
| sihl-*/test/dune | Reformatted all test dune files for consistency |
| sihl-*.opam | Alphabetically sorted dependencies and added dev-setup tools across all packages |
| sihl-*.opam.locked | Removed all locked files |
| sihl-email.opam.template | Added pin-depends for letters package |
| dune-project | Updated dune language to 3.0 and reformatted dependencies alphabetically |
| .devcontainer/Dockerfile | Removed Node.js dependencies, updated to OCaml 5.4 and opam 2.3 |
| .devcontainer/devcontainer.json | Updated VS Code settings structure and OCaml sandbox configuration |
| .devcontainer/postCreate.sh | Simplified installation using new opam flags |
| .devcontainer/docker-compose.yml | Removed node_modules volume |
| template/.devcontainer/* | Updated template devcontainer to OCaml 5.4, kept Node.js for template usage |
| default.nix | Removed yarn from nix shell dependencies |
| Makefile | Simplified deps target to single opam command |
| .github/workflows/ci.yml | Added OCaml 5.3 to CI test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make formatandformatOnSave)