remove greetings text, active after import don't receive reminder#629
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Pool Tool’s admin/email settings and user-import reminder behavior by removing an unused i18n key, tightening reminder selection logic, and making SMTP “system account” checkbox handling more robust.
Changes:
- Exclude
active_after_import=trueuser imports from reminder selection queries. - Remove the
greetings_texti18n key from the typed key set and add a migration step to delete its persisted rows. - Make SMTP “system account” boolean decoding default to
falsewhen the checkbox is absent from submitted form data.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pool/web/view/page/page_admin_settings_smtp.ml | Sets explicit non-required behavior for the SMTP system-account checkbox. |
| pool/app/user_import/repo.ml | Adds active_after_import = 0 constraint to reminder candidate selection. |
| pool/app/pool_database/migrations/migration_202607071300.ml | Adds migration step to delete greetings_text rows from pool_i18n. |
| pool/app/i18n/i18n.mli | Removes GreetingsText from the public i18n key variant type. |
| pool/app/i18n/entity.ml | Removes GreetingsText from the i18n key entity variant definitions. |
| pool/app/email/entity_smtp.ml | Sets a default false value for SMTP system-account schema decoding. |
mabiede
force-pushed
the
feature/2545-review
branch
from
July 10, 2026 06:46
07e87f0 to
1949cae
Compare
PossessedC0bra
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.