test: expect the hidden-duplicate item in the context menu item texts - #251
Merged
Merged
Conversation
The shared `ContextMenuView` gained a visible "Duplicated Hidden" item after the `getItemTexts()` test was written, so the expected texts were one item short and the test failed once both changes were on `main`.
Collaborator
|
Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 25.3, i have encountered the following issue. Can you take a look and pick it manually? |
mcollovati
added a commit
that referenced
this pull request
Sep 18, 2026
The item texts expectation in `ContextMenuTesterTest` was one item short, so this cherry-pick branch failed CI. The list now names every item a user sees. The mismatch comes from two changes that never met before landing: the test fixture gained a visible "Duplicated Hidden" item in #238, which is already on 25.3, while #242 was written on a branch cut before that. Cherry-pick of #251.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The context menu test that checks which item texts a menu reports was
one item short, so it failed on
mainand on the 25.3 cherry-pick(#247). The expectation now lists every item a user sees.
The two changes involved never met in CI: the test fixture gained a
visible "Duplicated Hidden" item in #238, while #242 was written and
validated on a branch cut before that. The files merged without a
textual conflict, so the mismatch only showed up after both had
landed.
What changed
getItemTexts_hiddenItemIgnored_componentItemHasNoTextexpectsDuplicated Hiddenas the last top level text, next to the nine italready listed.
Test summary
including the visible one of the two
Duplicated Hiddensiblings,which pins down that only the hidden sibling is left out.