Skip to content

ci: point the @since reconciliation at the real module source roots (#258) (CP: 25.3) - #259

Merged
Artur- merged 1 commit into
25.3from
cherry-pick-258-to-25.3-1790072057675
Sep 22, 2026
Merged

Artur- merged 1 commit into
25.3from
cherry-pick-258-to-25.3-1790072057675

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #258 to branch 25.3.

Original PR description

Summary

The "Update @SInCE tags" workflow ran but never changed anything, because it looked for Java sources in directories that do not exist in this repo. This fixes the paths so the reconciliation actually finds our code.

What changed

CI only — no product code or public API is touched, so nothing changes for users of the library.

  • The reconcile-since-tags action defaults each artifact's source root to <artifactId>/src/main/java. Our module directories are named after the module (shared, junit6, spring, quarkus), not after the published artifact, so every source root was missing and all four modules were skipped. The workflow finished green in under a minute with an empty diff and no PR.
  • Source roots are now spelled out with the action's <artifact>=<source-root> syntax. A local run reconciles 39 files.
  • Bumped the pinned action version. The new version fails the run when a configured source root does not exist, instead of skipping it quietly, so this kind of misconfiguration cannot pass unnoticed again. It also refuses to build an index from a failed release download.
  • Added .since-index (the action's local cache directory) to .gitignore.

…258)

## Summary
The `@since` tag workflow never updated anything, because it looked for
source files in folders that do not exist. This change tells it where
each module's sources really live, so the workflow can do its job again.

## What changed
This is a CI-only change. No production code, no API change, nothing for
users of the library to adapt.

- The `reconcile-since-tags` action assumes each artifact's sources are
in `<artifactId>/src/main/java`. Our directories are named after the
module (`shared`, `junit6`, `spring`, `quarkus`), not after the
published artifact, so every source root was missing and all four
modules were skipped. The workflow then finished in under a minute with
no changes and no pull request.
- The `artifacts` list in `.github/workflows/update-since-tags.yml` now
spells out each source root with the action's `<artifact>=<source-root>`
syntax. A local run reconciles 39 files.
- Added `.since-index` to `.gitignore` so the local index the action
writes is not committed by accident.

Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Artur-
Artur- enabled auto-merge (squash) September 22, 2026 10:20
@Artur-
Artur- merged commit f5c1f78 into 25.3 Sep 22, 2026
6 checks passed
@Artur-
Artur- deleted the cherry-pick-258-to-25.3-1790072057675 branch September 22, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants