Conversation
Browserless Test 1.2 adds testers and tester methods that the Component Testers page does not mention, and it changes what a value tester does with a value that breaks a constraint. - Common Testers: rows for TreeGrid, SplitLayout, Card, AvatarGroup, Accordion, Dashboard, Text, and Markdown; new methods on TextField, Checkbox, NumberField, Grid, Dialog, Upload, Breadcrumbs, and Switch. - Constraint Enforcement: a constraint the browser enforces before the value is entered still makes the tester throw, while min, max, step, and required values are committed and leave the field invalid, which isValid() asserts. - Clearing a Value: clear() models the keyboard, clickClearButton() needs a visible clear button, and selection testers have their own wording. - Tester interactions reach the application as client-originated events. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
I don't get this point. Version 1.2 will never be released because we moved directly to 25.3. All mentioned methods seem to be in 25.3 |
Contributor
|
Should also mention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browserless Test 1.2 is what Vaadin 25.3 ships. It adds seven testers and a set of tester methods that the Component Testers page does not mention, and it changes what a value tester does with a value that breaks a constraint. The page currently tells a test author the opposite of what the code does.
Covered here:
vaadin/browserless-test#211—NumberFieldTester,DatePickerTester,TimePickerTesterandDateTimePickerTesterno longer throw onmin/max/step/ required violations. They commit the value and leave the field invalid, andisValid()asserts the outcome. The page's Constraint Enforcement example claimed the opposite.vaadin/browserless-test#189—TreeGridTesterwithexpand,collapse,isExpandedandhasChildren.vaadin/browserless-test#197—SplitLayoutTester,CardTesterandAvatarGroupTester.vaadin/browserless-test#187—GridTester.deselect(int)anddeselectAll().vaadin/browserless-test#186—AccordionTester.closeDetails()andtoggleDetails(String).vaadin/browserless-test#191—NumberFieldTester.stepUp()/stepDown()andisValid().vaadin/browserless-test#183—DialogTester.pressEscape()andclickOutside().vaadin/browserless-test#168— a uniformclear()plus the newclickClearButton().vaadin/browserless-test#185—CheckboxTester.check()/uncheck()andSwitchTester.switchOn()/switchOff().vaadin/browserless-test#198—UploadTesterenforcesmaxFiles,maxFileSizeand accepted types, and addsgetLastUploadStatus()andensureUploaded().vaadin/browserless-test#188— tester interactions reach the application as client-originated events.Four testers released earlier, in 1.1.2, never reached the docs either, so they are added with a
V25.2badge:DashboardTester(vaadin/browserless-test#105),BreadcrumbsTester.getItemPaths()(vaadin/browserless-test#107),TextTester(vaadin/browserless-test#135) andMarkdownTester(vaadin/browserless-test#132).What changed
In
articles/flow/testing/browserless/component-testers.adoc:isFromClient()behaves as it does in a running application.TreeGrid,Accordion,SplitLayout,Card,AvatarGroup,Dashboard,TextandMarkdown, and new methods on theTextField,Checkbox,NumberField,Grid,Dialog,Upload,BreadcrumbsandSwitchrows.maxLengthor an allowed character pattern, still makes the tester throw. A constraint that only marks the field invalid is committed, as a browser commits it, and asserted withisValid().clear()versusclickClearButton(), and the wording selection testers use instead.Notes for the reviewer
vaadin/browserless-test#185and#198are merged but landed after the1.2.0-rc1tag, so they are not in rc1. They need 1.2.0 final to ship with 25.3. If the release does not pick them up, drop thecheck()/uncheck(),switchOn()/switchOff(),getLastUploadStatus()andensureUploaded()entries.vaadin/browserless-test#211is breaking for existing tests that assertassertThrows(IllegalArgumentException.class, ...). The upgrade-guide note is docs: add the browserless behavior changes to the upgrade guide #6101.Dashboardis a commercial component, like theGridProandChartrows already in the table.How to test
Documentation only, with inline snippets that are not compiled. The behavior matches
NumberFieldTester,TreeGridTester,AccordionTester,DialogTester,UploadTesterand the other testers onvaadin/browserless-testmain.🤖 Generated with Claude Code