Conversation
A query walks the server-side component tree, so it misses a component that a renderer creates per item and the content of a closed overlay. The page said nothing about either, and the empty result reads as a missing component rather than an unrendered one. Adds a section covering component columns, the GridTester methods that reach those components, Lit renderer columns, and overlay content, and records that Grid header, footer, and editor components are part of the tree as of Vaadin 25.3. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mcollovati
self-requested a review
September 21, 2026 08:55
mcollovati
requested changes
Sep 21, 2026
| A query walks the server-side component tree. A component that another component renders per item, and the content of an overlay that is closed, are not in that tree, and a query returns an empty result for them instead of an error. The failure therefore reads as though the component was never created. | ||
|
|
||
|
|
||
| === Components a Renderer Creates |
Contributor
There was a problem hiding this comment.
This paragraph should be revisited to be consistent with changes in vaadin/browserless-test#250 that should prevent renderer components to be created and attached again and again.
Contributor
Preview DeploymentThis PR has been deployed for preview. URL: https://docs-preview-pr-6090.fly.dev Changed pagesAdded content is highlighted in green; removed content is marked in red on each page.
Built from de18f1a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find()walks the server-side component tree, and two kinds of component are not in it when a test looks for them: a component that a renderer creates per item, and the content of an overlay that is closed. Both return an empty result rather than an error, so the failure reads as a missing component instead of an unrendered one. The Querying Components page did not mention either case, and the repository documented it only in its README (vaadin/browserless-test#219).The same section records the fix in
vaadin/browserless-test#203: a component set as a Grid column header, footer, or editor is now part of the tree, where a query used to fail with "no such component". It is reported once, even in a header cell that spans several columns.What changed
In
articles/flow/testing/browserless/component-query.adoc, a new Components a Query Cannot Find section with two subsections:find(Checkbox.class)finds nothing for a component column, howGridTester.getCellComponent(...)renders the cell on request, the warning that every call attaches a new instance, theLitRenderermethods for columns that have no server-side component, and theV25.3note about header, footer, and editor components.Notes for the reviewer
vaadin/browserless-test#203shipped in 1.2.0-rc1, which is what Vaadin 25.3 ships, hence theV25.3badge on that one sentence. The rest of the section describes behavior that has always been there.How to test
Documentation only, with inline snippets that are not compiled. The behavior matches
GridTesterandContextMenuTesteronvaadin/browserless-testmain, where tests pin both cases.🤖 Generated with Claude Code