Conversation
navigate("order/ORD-1?tab=history", OrderView.class) used to fail with
"Base path can not contain query separator=?". The mocked UI now parses
the location the way Flow does, so the query parameters reach the view.
Documents the supported form and says which navigate() argument carries
route template parameters instead.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
This has also been documented here #6076 along with other changes. |
mcollovati
reviewed
Sep 21, 2026
| ---- | ||
|
|
||
| The view reads those query parameters from the navigation event, as it does in a running application. The map that [methodname]`navigate(Template.class, Map)` takes holds route template parameters instead, so a query string belongs in the location string. | ||
|
|
Contributor
There was a problem hiding this comment.
A potential addition from #6076
A location consisting only of a fragment, such as
"#details", identifies a place within the current page rather than a route, so it leaves the current view in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
navigate("order/ORD-1?tab=history", OrderView.class)used to fail withBase path can not contain query separator=?, so a test could not reach a view through a location with query parameters. The mocked UI now parses the location the way Flow'sUI.navigatedoes (vaadin/browserless-test#204), and the query parameters reach the view. Nothing on the Getting Started page said the location could carry them.What changed
In
articles/flow/testing/browserless/getting-started.adoc, under Navigating to Views: one badged sentence, a snippet, and a line saying that the map taken bynavigate(Template.class, Map)holds route template parameters, which is the mistake the old wording invited.Notes for the reviewer
V25.3badge.QueryParametersargument toUI.navigatenow fails with a message naming the location. Neither case seemed worth a paragraph on a getting-started page; say the word if they belong here.How to test
Documentation only, with an inline snippet that is not compiled. The behavior matches
MockedUI.navigateand the navigation tests onvaadin/browserless-testmain.🤖 Generated with Claude Code