feat: Adds relevant API to allow drag and drop to a certain location#23187
Open
feat: Adds relevant API to allow drag and drop to a certain location#23187
Conversation
Test case derived from a community feedback/question
…ation Added offset coordinates related to start and drop of the operation.
mcollovati
changed the title
|
caalador
reviewed
Jan 13, 2026
| public Optional<Integer> getDragStartOffsetX() { | ||
| return getDragSourceComponent().map(component -> (Integer) ComponentUtil | ||
| .getData(component, DndUtil.DRAG_START_OFFSET_X_KEY)); | ||
| } |
Contributor
There was a problem hiding this comment.
These could perhaps return int and if getData returns null return 0 by default
Suggested change
| } | |
| public int getDragStartOffsetX() { | |
| return getDragSourceComponent().map(component -> (Integer) ComponentUtil | |
| .getData(component, DndUtil.DRAG_START_OFFSET_X_KEY)).orElse(0); | |
| } |
Same for OffsetY
Contributor
There was a problem hiding this comment.
Could add a junit test where the DragStartEvent has a non 0 offset value and drag ed event would validate the getDragStartOffsetX and getDragStartOffsetY values.
caalador
requested changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes clientX/Y for all D&D events, to allow "repositioning" absolutely positioned drag and drop component. Also exposing offsets of the target and start element (if operation started on top of Vaadin component), so that one can build UIs where "things" are dragged on a specific location of another component.
Fixes #19297
Type of change