Open
Conversation
Test Results1 263 files - 119 1 263 suites - 119 1h 23m 38s ⏱️ -2s For more details on these errors, see this check. Results for commit 2f6f831. ± Comparison against base commit 2a81ded. This pull request removes 1294 and adds 11 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
knoobie
reviewed
Feb 16, 2026
flow-server/src/main/java/com/vaadin/flow/component/geolocation/Geolocation.java
Outdated
Show resolved
Hide resolved
|
Provides access to the browser's Geolocation API with two usage modes: - get(): one-shot position request with success/error callbacks - track(): continuous tracking via a reactive Signal tied to a component's lifecycle, using a GeolocationState sealed type (Pending | GeolocationPosition | GeolocationError) that enables exhaustive pattern matching Includes records for coordinates, position, error, and options, a JS module that bridges navigator.geolocation to Vaadin's event system, and unit + integration tests.
github-project-automation
bot
moved this to 🔎Iteration reviews
in Vaadin Flow | Hilla | Kits ongoing work
|
platosha
requested changes
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Would it make sense to convert this to TypeScript and move to flow-client?
Contributor
There was a problem hiding this comment.
In addition, please make sure that TypeScript would have clear JSON event data definitions. This would help matching any changes with Java in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps the browser's Geolocation API with two entry points:
Geolocation.get()for one-shot positionGeolocation.track()for continuous tracking via Signals, automatically tied to the owner component's lifecycle