Skip to content

Pass --no-frozen-lockfile in pnpm dev mode to prevent CI failures (#23794) (CP: 25.1)#23842

Merged
vaadin-bot merged 1 commit into25.1from
cherry-pick-23794-to-25.1-1773302968750
Mar 12, 2026
Merged

Pass --no-frozen-lockfile in pnpm dev mode to prevent CI failures (#23794) (CP: 25.1)#23842
vaadin-bot merged 1 commit into25.1from
cherry-pick-23794-to-25.1-1773302968750

Conversation

@vaadin-bot
Copy link
Collaborator

This PR cherry-picks changes from the original PR #23794 to branch 25.1.

Original PR description

Summary

  • pnpm 10 auto-enables --frozen-lockfile when it detects CI environments
    (via ci-info, checking GITHUB_ACTIONS, CI, etc.)
  • Flow never requests this: ciBuild defaults to false in dev mode
  • When a user bumps vaadin.version and pushes, the stale pnpm-lock.yaml
    causes ERR_PNPM_LOCKFILE_CONFIG_MISMATCH in CI but works locally
  • Fix: explicitly pass --no-frozen-lockfile when running pnpm install
    in dev mode (ciBuild==false), since Flow is resolving dependencies,
    not reproducing a locked build

Context

When ciBuild==true, Flow already passes --frozen-lockfile explicitly.
This change makes the non-CI path equally explicit, preventing pnpm from
silently inheriting a stricter mode based on environment detection.

Fixes #23530

…3794)

pnpm 10 auto-enables --frozen-lockfile when it detects CI via ci-info,
causing ERR_PNPM_LOCKFILE_CONFIG_MISMATCH when overrides change between
Vaadin versions. Explicitly pass --no-frozen-lockfile in dev mode
(ciBuild==false) since Flow is resolving dependencies, not reproducing
a locked build.

Revert isPlatformMajorVersionUpdated changes as the lockfile flag
approach fixes the root cause.
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) March 12, 2026 08:19
@sonarqubecloud
Copy link

@github-actions
Copy link

Test Results

 1 382 files  ±0   1 382 suites  ±0   1h 24m 19s ⏱️ - 1m 40s
 9 889 tests ±0   9 818 ✅ ±0  71 💤 ±0  0 ❌ ±0 
10 362 runs  ±0  10 282 ✅ ±0  80 💤 ±0  0 ❌ ±0 

Results for commit 845eaae. ± Comparison against base commit 0661df4.

@vaadin-bot vaadin-bot merged commit e145f1c into 25.1 Mar 12, 2026
30 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-23794-to-25.1-1773302968750 branch March 12, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants