chore: Drop obsolete NullAway workarounds - #25311
Merged
Merged
Conversation
NullAway reads @nullable off record components, so GeolocationOptions uses a compact constructor instead of a spelled-out canonical one. @nullable on the declared type is enough for NullAway to infer the constructor and generic method type arguments, so the repeated type arguments and explicit type witnesses in the signal tests are gone. DESIGN_GUIDELINES.md described both patterns as requirements.
Artur-
enabled auto-merge
August 26, 2026 08:24
vaadin-review-bot
approved these changes
Aug 26, 2026
Collaborator
|
@Artur- this "chore:"/"test:" PR has been approved automatically, but auto merge has not been enabled for it. You can enable the auto merge by yourself, or ask another member for another review. [Message is sent from bot] |
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NullAway reads @nullable off record components, so GeolocationOptions uses a compact constructor instead of a spelled-out canonical one.
@nullable on the declared type is enough for NullAway to infer the constructor and generic method type arguments, so the repeated type arguments and explicit type witnesses in the signal tests are gone.
DESIGN_GUIDELINES.md described both patterns as requirements.