test: retry the TestKit Gradle distribution download in gradle-plugin tests (#6014) (CP: 24.10) - #6018
Open
vaadin-bot wants to merge 3 commits into
Open
test: retry the TestKit Gradle distribution download in gradle-plugin tests (#6014) (CP: 24.10)#6018vaadin-bot wants to merge 3 commits into
vaadin-bot wants to merge 3 commits into
Conversation
… tests (#6014) The functional tests run the build under test with a pinned Gradle version, which TestKit downloads from services.gradle.org. A network hiccup during that download fails the test before the build even starts, which took out four tests on the Windows runner with "Could not install Gradle distribution from ... Unexpected end of file from server". Retry the build up to three times when it fails while installing or connecting to the distribution. Failures of the build under test are rethrown as before.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 24.10 #6018 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 123 123
Lines 8489 8489
Branches 1307 1307
=======================================
Hits 7354 7354
Misses 1116 1116
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The distribution-download retry logs the Gradle version being downloaded, but on this branch the version was hardcoded inside createGradleRunner, so the reference did not compile. Expose it as a constructor property, as on main.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.