Draft
Conversation
TestBenchElement.click() was using JavaScript's element.click(), which does not produce the same browser events as a real user click. This made click() behave differently from click(x, y), doubleClick(), and contextClick(), which all use Selenium Actions and correctly simulate user interactions. Side effects include missing or incorrect browser event properties such as click count. Replace the default click() implementation with Selenium Actions.click(), consistent with the other click methods. The old JavaScript-based click logic is extracted into a new javascriptClick() method for cases where Selenium cannot reach the element directly. A useJavascriptClick parameter is added to Parameters for backwards compatibility, allowing existing projects to restore the old behavior via system property or programmatic setter. Fixes #2155
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestBenchElement.click() was using JavaScript's element.click(), which does not produce the same browser events as a real user click. This made click() behave differently from click(x, y), doubleClick(), and contextClick(), which all use Selenium Actions and correctly simulate user interactions. Side effects include missing or incorrect browser event properties such as click count.
Replace the default click() implementation with Selenium Actions.click(), consistent with the other click methods. The old JavaScript-based click logic is extracted into a new javascriptClick() method for cases where Selenium cannot reach the element directly.
A useJavascriptClick parameter is added to Parameters for backwards compatibility, allowing existing projects to restore the old behavior via system property or programmatic setter.
Fixes #2155