fix: ensure overridden notUsableReasons is called by ensureComponentIsUsable#2162
Merged
mcollovati merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
…ntIsUsable` When a `ComponentTester` subclass overrides `notUsableReasons`, the override was never invoked when building error messages, causing subclass-specific reasons (e.g. "read only", "not opened") to be missing from the exception. Fixed by routing the instance method through virtual dispatch so that subclass overrides are properly picked up.
caalador
approved these changes
Mar 6, 2026
mcollovati
added a commit
that referenced
this pull request
Mar 6, 2026
…ntIsUsable` (#2162) When a `ComponentTester` subclass overrides `notUsableReasons`, the override was never invoked when building error messages, causing subclass-specific reasons (e.g. "read only", "not opened") to be missing from the exception. Fixed by routing the instance method through virtual dispatch so that subclass overrides are properly picked up.
caalador
pushed a commit
that referenced
this pull request
Mar 6, 2026
…ntIsUsable` (#2162) (#2163) When a `ComponentTester` subclass overrides `notUsableReasons`, the override was never invoked when building error messages, causing subclass-specific reasons (e.g. "read only", "not opened") to be missing from the exception. Fixed by routing the instance method through virtual dispatch so that subclass overrides are properly picked up.
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
…ntIsUsable` (#2162) (#2163) When a `ComponentTester` subclass overrides `notUsableReasons`, the override was never invoked when building error messages, causing subclass-specific reasons (e.g. "read only", "not opened") to be missing from the exception. Fixed by routing the instance method through virtual dispatch so that subclass overrides are properly picked up.
mshabarov
pushed a commit
that referenced
this pull request
Mar 9, 2026
…ntIsUsable` (#2162) (#2163) (#2165) When a `ComponentTester` subclass overrides `notUsableReasons`, the override was never invoked when building error messages, causing subclass-specific reasons (e.g. "read only", "not opened") to be missing from the exception. Fixed by routing the instance method through virtual dispatch so that subclass overrides are properly picked up. Co-authored-by: Marco Collovati <marco@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
ComponentTestersubclass overridesnotUsableReasons, the override was never invoked when building error messages, causing subclass-specific reasons (e.g. "read only", "not opened") to be missing from the exception.Fixed by routing the instance method through virtual dispatch so that subclass overrides are properly picked up.