MoriUI: move terminal tabs into the window titlebar (Chrome-style)#95
Merged
Conversation
Replace the separate 34pt tab strip above the terminal with a native AppKit tabs view hosted as a toolbar item in the titlebar, filling the previously-empty space between the left and right toolbar icon groups. This reclaims a full row of vertical height for the terminal. The tabs are native AppKit (NSStackView of NSControl pills), not SwiftUI: hosting SwiftUI inside an NSToolbar flexible-space layout repeatedly rendered as a blank strip. A low-priority oversized tail spacer absorbs the slack so every tab keeps a fixed 160pt width, left-aligned with empty space on the right, without NSStackView's `.fill` stretching the first tab and without triggering toolbar overflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the terminal tabs from a separate 34pt strip above the terminal into the window titlebar, Chrome-style. The tabs fill the previously-empty titlebar space between the left and right toolbar icon groups, reclaiming a full row of vertical height for the terminal.
How
TerminalTabsBarView— a native AppKit tabs view (NSStackViewofNSControlpills ++button), hosted as anNSToolbarItemin the titlebar.NSToolbarflexible-space layout it repeatedly rendered as a blank strip. Native AppKit renders reliably.withObservationTrackingrebuilds the tabs when@ObservableAppState changes.MainWindowControllerlays out three groups — left icons / tabs strip / right icons — and dynamically sizes the tabs strip to fill the gap between the icon groups (recomputed on resize), with symmetric ~39pt margins..fillstretching the first tab and without triggering toolbar overflow.TerminalAreaViewController.Verification
mise run test✅ (all packages)swift build -c release --product Mori✅ (Swift 6 strict concurrency clean)bundle.sh+ launch smoke ✅tabWidths=[160.0, 160.0], all toolbar items visible (no overflow»),leftMargin=39 rightMargin=39at two window widths.🤖 Generated with Claude Code