Open
Conversation
maartenbreddels
requested changes
Oct 3, 2022
Member
maartenbreddels
left a comment
maartenbreddels
left a comment
There was a problem hiding this comment.
cool work, just some small code comments
Comment on lines
+7073
to
+7075
| if lines: | ||
| if not first: | ||
| raw = raw.replace('},', '}\n') |
Member
There was a problem hiding this comment.
this will probably go wrong when having nested data (which will contain }), or string data containing a }.
what about just wring a \n separately? although I see we already do it at line 7077? so two newlines?
Member
Author
There was a problem hiding this comment.
if we want the from_json_arrow to work, i can't get it to work otherwise.. it requires that each json record is on a new line, and cant end with a trailing comma. I do understand your concerns tho..
…t additional json export backends.
JovanVeljanoski
force-pushed
the
feat_from_json_arrow
branch
from
d98e72d to
b85f321
Compare
maartenbreddels
force-pushed
the
master
branch
from
c8549a7 to
f304f80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does:
vaex.from_json_arrowmethod that is significantly faster way of reading JSON recordsdf.export_json()now accepts "backend" and "lines" arguments.To-Do (to be handled in a separate PR):