Adding the possibility to pick a specified size#104
Open
s43 wants to merge 1 commit intovafour:masterfrom
s43:patch-1
Open
Adding the possibility to pick a specified size#104s43 wants to merge 1 commit intovafour:masterfrom s43:patch-1
s43 wants to merge 1 commit intovafour:masterfrom
s43:patch-1
Conversation
Basically the variable "attachment.url" gives in return the full size of the image, I've been through a case where I needed to pick a specific cropped size, otherwise the images shows up in a bad resolution on the front-end. The Wp media editor returns gives is to arguments, props has an object with the selected size it, and attachment has almost everything about the file, including the sizes with it urls. I fixed it for my self, and I wanted to share it with others, and hopefully it may be helpful :). Thanks for the good work guys, keep it up!
|
@s43 Maybe, you are interested to create a similar pull request for https://github.com/moewe-io/favpress.com Thanks, Adrian |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the variable "attachment.url" gives in return the full size of the image, I've been through a case where I needed to pick a specific cropped size, otherwise the images shows up in a bad resolution on the front-end.
The Wp media editor gives in return two arguments, props has an object with the selected size, and attachment has almost everything about the file, including the sizes with it urls.
I fixed it for my self, and I wanted to share it with others, and hopefully it may be helpful :).
Thanks for the good work guys, keep it up!