Add Windows Support #161
Open
Add Windows Support #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
404Wolf
force-pushed
the
fix-windows-paths
branch
3 times, most recently
from
b8134ee to
6ed6751
Compare
404Wolf
force-pushed
the
fix-windows-paths
branch
2 times, most recently
from
d39c3dd to
fbf1c91
Compare
404Wolf
force-pushed
the
fix-windows-paths
branch
from
fbf1c91 to
914d1d7
Compare
404Wolf
force-pushed
the
fix-windows-paths
branch
2 times, most recently
from
7ef56ef to
7ef610e
Compare
404Wolf
force-pushed
the
fix-windows-paths
branch
from
7ef610e to
7d3971c
Compare
404Wolf
force-pushed
the
fix-windows-paths
branch
2 times, most recently
from
f8234ec to
192e9a1
Compare
404Wolf
force-pushed
the
fix-windows-paths
branch
from
192e9a1 to
7565fd6
Compare
Collaborator
Author
|
@maxmcd can I merge this? |
Collaborator
Author
|
@maxmcd can I get a review on this? This branch is continuing to fall behind and vt is still broken on windows. |
404Wolf
force-pushed
the
fix-windows-paths
branch
3 times, most recently
from
b3fa5fa to
efe0fbe
Compare
404Wolf
force-pushed
the
fix-windows-paths
branch
from
efe0fbe to
7c5843b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support windows style paths :(. Achieved via
asPosixPathand abstracting all API methods to utilities insdk.ts(which I have mixed feelings about, but feels like it's for the better).