Fix batched tier-2 dispatch cancellation in fetch_proofs#108
Merged
Conversation
Replace fail-fast try_join_all in fetch_proofs with join_all so one failing note cannot cancel sibling futures before they send tier-2 queries, and add a deterministic regression test plus changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try_join_allinPirClient::fetch_proofswithjoin_all, then return errors only after all per-note futures completeCHANGELOG.mdTest plan
cargo test -p pir-client batched_ -- --nocapture